Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that debug --rootpw enables SSH and changes the default password #738

Closed
stuclem opened this issue Sep 6, 2017 · 5 comments
Closed

Comments

@stuclem
Copy link
Contributor

stuclem commented Sep 6, 2017

From Slack:

Eduardo Meirelles [7:47 PM]
BTW… not sure if you guys have a chance to look at --rootpw behavior…when I ran debug --rootpw it also enabled SSH access, even though I did not specify --enable-ssh option.

Matt Williamson [8:00 PM]
i just confirmed that using the rootpw flag in 1.1.1 also enabled ssh access.

[8:00]
the docs should be updated to reflect that rootpw enables SSH AND changes the default password

[8:00]
where enable_ssh turns it on with the default password

@stuclem stuclem added product/engine Related to the vSphere Integrated Containers Engine area/pub Published documentation for end-users area/pub/vsphere Published documentation for vSphere administrators labels Sep 6, 2017
@stuclem stuclem self-assigned this Sep 6, 2017
@stuclem
Copy link
Contributor Author

stuclem commented Sep 18, 2017

@mdubya66 and @emeirell if I remember correctly the discussions that I had with @hickeng at the time that he added these options, this is actually a bug in the implementation of --rootpw.

I believe that the intention is for vic-machine debug to work as documented, i.e. --rootpw activates Shell access only, and then if used in combination with --enable-ssh, it enables shell and SSH access, using the same password. I can't fully remember why this separation was necessary, but @hickeng and I did go around the houses a few times when I wrote up these topics (with substantial contribution from @hickeng, IIRC).

Of course, even if the docs do present the desired behaviour, they do not present the actual behaviour. So, we have two options:

  • Make the current behaviour the official behaviour and rewrite the docs accordingly.
  • Fix the implementation of --rootpw in the product, and in the meantime, document the fact that --rootpw also enables SSH as a Known Issue in the release notes.

Which do you prefer?

@stuclem stuclem added the kind/question A request for information label Sep 18, 2017
@emeirell
Copy link

Fixing the implementation of --rootpw seems the right thing to do.
This security granularity control is greatly appreciated within customers.

@stuclem
Copy link
Contributor Author

stuclem commented Sep 21, 2017

In the meantime, I'll add this as a Known Issue in the release notes.

@stuclem stuclem added the impact/doc/note Requires creation of or changes to an official release note label Sep 21, 2017
@stuclem
Copy link
Contributor Author

stuclem commented Sep 21, 2017

Moving this to the vic repo, as this is an engineering issue rather than a doc issue. I did not find an existing issue about --rootpw enabling SSH.

@stuclem stuclem removed product/engine Related to the vSphere Integrated Containers Engine area/pub Published documentation for end-users area/pub/vsphere Published documentation for vSphere administrators kind/question A request for information labels Sep 21, 2017
@stuclem stuclem removed their assignment Sep 21, 2017
@stuclem
Copy link
Contributor Author

stuclem commented Sep 21, 2017

Issue moved to vmware/vic #6402 via ZenHub

@stuclem stuclem closed this as completed Sep 21, 2017
@stuclem stuclem removed the impact/doc/note Requires creation of or changes to an official release note label Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants