Port groups under a network folder don't show up in the wizard

[jooskim]

do not merge until after 1.4 release is tagged

VIC-UI version:
1.3

Additional details:
Customers reported that in the Create VCH wizard they don't see port groups for switches they have in the VC inventory. Port groups that did not show up were under a network folder.

Steps to reproduce:

1. Create a network folder in VC and create at least one distributed virtual switch, and add at least a host to it
2. Create two port groups for the switch
3. In the wizard try to create a VCH using the two port groups for bridge and client network respectively

Actual behavior:
Port groups do not show up

Expected behavior:
User should be able to see and select the port groups

[jooskim]

Initial findings:

1. All of our use cases so far have been under an assumption that DV switches are always on the root level, but once you nest them under a network folder, they do not get picked up by the UI
2. According to getDistributedPortGroups() in create-vch-wizard.service.ts we perform the following operations to get the list of port groups of the given DC object:

• get networking tree for a given DC object
• filter them such we get only entires of type DcDvs
• make API calls to get DV portgroup entries and their host entries information

3. The problem with this approach is that it assumes that there would be only nodes whose nodeTypeId is DcDvs that the user can choose from, when the user should also be able to choose from a folder. In this case, a folder has nodeTypeId DcNetworkFolder and /ui/tree/children call should be made recursively to fetch all the leaf nodes with type DcDvs, and get host entries information for these.

[mlh78750]

Another customer experienced this issue as reported on internal slack.

[andrewtchin]

Add a test as part of this story