Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Support organization name #89

Open
RudraSen2 opened this issue May 23, 2022 · 7 comments
Open

[Feature request] Support organization name #89

RudraSen2 opened this issue May 23, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@RudraSen2
Copy link

Describe the bug
My Personal GitHub Usernames are working with this but my Organisation Username is not working.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to 'https://github-profile-summary-cards.vercel.app/demo.html'
  2. Type Username as 'Facebook', or any GitHub organisation username.
  3. See error - It's all blank

Expected behaviour
It should display stats like other personal GitHub usernames.

Screenshots
Personal Account:
image

Organisation Account:
image

Desktop:

  • OS: Windows 11 Pro Dev Insider Build 25120.1010
  • Browser Google Chrome Latest Version

Smartphone:
Not Applicable

Additional context
Nothing.

@leo-schick
Copy link

Same for me, but profile-summary-for-github.com works with organizations quite fine

@vn7n24fzkq
Copy link
Owner

That's odd.

I will investigate it on the weekend.

@vn7n24fzkq vn7n24fzkq added the bug Something isn't working label Jun 30, 2022
@vn7n24fzkq
Copy link
Owner

vn7n24fzkq commented Jul 3, 2022

Hi, I just found the cause.

In GitHub Graph API, user and organization data use different query.

Organization :

{
  organization(login: "facebook") {
    id
  }
}

User :

{
  user(login: "vn7n24fzkq") {
    id
  }
}

You can find it in the API explorer
https://docs.github.com/en/graphql/overview/explorer

We can add the getting organization cards feature if this is useful.

What do you think?
In my opinion, I think we can add the organization parameter. (Auto-detection would make it easier to use, but make more unnecessary API requests)

@leo-schick
Copy link

Yes 🙌 would be great to have this feature. Maybe use a parameter to define if the given name is a user or organization

@vn7n24fzkq
Copy link
Owner

Good! I will add this feature.

@vn7n24fzkq vn7n24fzkq added enhancement New feature or request and removed bug Something isn't working labels Jul 3, 2022
@RudraSen2
Copy link
Author

Any progress?

@vn7n24fzkq vn7n24fzkq changed the title [BUG] Doesn't Support Organisation Usernames [Feature request] Support Organisation Usernames Jul 29, 2022
@vn7n24fzkq vn7n24fzkq changed the title [Feature request] Support Organisation Usernames [Feature request] Support organization name Jul 29, 2022
@vn7n24fzkq
Copy link
Owner

vn7n24fzkq commented Jul 29, 2022

Not started this one yet.

I will add a parameter here.

And some data from GitHub GraphQL API may have different formats or even not exist between user and organization, so need to do some investigation here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants