Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Have default spect_output_dir be output_dir not data_dir #573

Closed
Tracked by #614
NickleDave opened this issue Aug 29, 2022 · 1 comment
Closed
Tracked by #614

ENH: Have default spect_output_dir be output_dir not data_dir #573

NickleDave opened this issue Aug 29, 2022 · 1 comment
Labels
ENH: enhancement enhancement; new feature or request

Comments

@NickleDave
Copy link
Collaborator

NickleDave commented Aug 29, 2022

Is your feature request related to a problem? Please describe.
Currently vak.io.dataframe.spect_output_dir defaults to data_dir

spect_output_dir = data_dir

This seemed like a logical choice at the time but it has the nasty effect of making tons of sub-directories full of .npz files in a directory you might not be paying much attention to.

For example, just had to fix this happening with tests: #571

Describe the solution you'd like
A better choice might be to default to output_dir? Since this is a directory we will be paying attention to as we work with models.

Describe alternatives you've considered
(1) Keep things as they are.

(2) And maybe have output_dir default to data_dir inside cli.prep? '
I.e., the default is to have spectrogram files to live besides the audio files they were generated from, unless a user really wants them to go somewhere else.

The drawback to this is that we then have a default that can easily overwrite existing spectrogram files, which we may not want to do. And those spectrogram files might be expensive to generate, depending on the algorithm and data!

Could make this opt-in, i.e. by specifying the same dir as data_dir for output_dir

@NickleDave NickleDave added the ENH: enhancement enhancement; new feature or request label Aug 29, 2022
@NickleDave
Copy link
Collaborator Author

Going to have prep create datasets as directories with standardized format; see #650.

Doing so will require removing this option anyway: spectrograms will always get saved in the directory.
Hence, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENH: enhancement enhancement; new feature or request
Projects
None yet
Development

No branches or pull requests

1 participant