Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preprocessing): add pre-classify command to manually classify files #527

Merged
merged 5 commits into from
Apr 30, 2023

Conversation

34j
Copy link
Collaborator

@34j 34j commented Apr 30, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2023

Codecov Report

Patch coverage: 1.49% and project coverage change: -0.40 ⚠️

Comparison is base (8eedc24) 20.15% compared to head (7a1636c) 19.76%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #527      +/-   ##
==========================================
- Coverage   20.15%   19.76%   -0.40%     
==========================================
  Files          38       39       +1     
  Lines        3309     3375      +66     
  Branches      447      462      +15     
==========================================
  Hits          667      667              
- Misses       2625     2691      +66     
  Partials       17       17              
Impacted Files Coverage Δ
src/so_vits_svc_fork/__main__.py 0.00% <0.00%> (ø)
...vits_svc_fork/preprocessing/preprocess_classify.py 0.00% <0.00%> (ø)
src/so_vits_svc_fork/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

README.md Outdated
@@ -209,7 +210,8 @@ Options:
Commands:
clean Clean up files, only useful if you are using the default file structure
infer Inference
onnx Export model to onnx
onnx
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to remove the onnx docstring?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, long time no see. ONNX support ended a long time ago, but I made a mistake in the order at that time.

raise NotImplementedError("ONNX export is not yet supported")
"""Export model to onnx"""

@34j 34j merged commit 7a0319c into main Apr 30, 2023
@34j 34j deleted the feat/add-pre-classify branch April 30, 2023 12:54
@34j
Copy link
Collaborator Author

34j commented Apr 30, 2023

@GarrettConway Would you be a collaborator? (Becoming a collaborator does not create any obligation, but it does add one more emoji to your README while creating the possibility of increased mental pain)
image
You can select your role

@GarrettConway
Copy link
Collaborator

@34j Sure, though I don't know how much time I'll be able to commit to it in the long run. I was astounded by the number of changes you all have made while I was off on vacation and just recently caught up. Big kudos to you and the rest.

@34j
Copy link
Collaborator Author

34j commented Apr 30, 2023

This repository is somewhat outdated and you should not spend too much time on it. (Although if I had more time, I would make all model parts replacable.) It is cursed because it has somewhat gained too much recognition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants