Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Request: AppImageLauncher #26702

Open
cwross opened this issue Nov 25, 2020 · 7 comments
Open

Package Request: AppImageLauncher #26702

cwross opened this issue Nov 25, 2020 · 7 comments
Labels
request Package request

Comments

@cwross
Copy link

cwross commented Nov 25, 2020

AppImageLauncher automates the process of creating .desktop files for easily integrating AppImages into your menus and desktop environment.

https://github.com/TheAssassin/AppImageLauncher

Thank you!

@ericonr ericonr added the request Package request label Nov 25, 2020
@tjaynl
Copy link

tjaynl commented Nov 28, 2020

i would also like this to be added to the repo's

@m4rcu5
Copy link

m4rcu5 commented Feb 4, 2021

Hi,

I took a stab at it in this m4rcu5@1bce018 commit.

It's not pretty as the package has some hard dependencies on systemd. It uses that for managing the user services appimagelauncherd. To get around this I disabled the daemon controls in the GUI and added a note to the end user, to take care of this themself.

image

First-time Void package builder here, so recommendations and improvements are welcome.

The package itself seems to work as intended on my machines, if you manage the daemon yourself.

@JJGadgets
Copy link

@m4rcu5 I seem to be getting make: *** No rule to make target 'libappimage'. Stop. Any idea why?
Attached log below.

❯ ./xbps-src pkg AppImageLauncher
=> xbps-src: updating repositories for host (x86_64)...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/x86_64-repodata' ...
x86_64-repodata: 1679KB [avg rate: 1617KB/s]
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/nonfree/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/debug/x86_64-repodata' ...
x86_64-repodata: 740KB [avg rate: 6453MB/s]
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/x86_64-repodata' ...
x86_64-repodata: 632KB [avg rate: 7182MB/s]
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/nonfree/x86_64-repodata' ...
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> AppImageLauncher-2.2.0_1: removing autodeps, please wait...
=> AppImageLauncher-2.2.0_1: building [cmake] for x86_64...
   [host] git-2.31.0_1: found (https://alpha.de.repo.voidlinux.org/current)
   [host] automake-1.16.2_2: found (https://alpha.de.repo.voidlinux.org/current)
   [host] pkg-config-0.29.2_2: found (https://alpha.de.repo.voidlinux.org/current)
   [host] libtool-2.4.6_6: found (https://alpha.de.repo.voidlinux.org/current)
   [host] wget-1.21.1_2: found (https://alpha.de.repo.voidlinux.org/current)
   [host] xxd-8.2.2513_1: found (https://alpha.de.repo.voidlinux.org/current)
   [host] desktop-file-utils-0.26_1: found (https://alpha.de.repo.voidlinux.org/current)
   [host] cmake-3.19.6_1: found (https://alpha.de.repo.voidlinux.org/current)
   [host] ninja-1.10.2_2: found (https://alpha.de.repo.voidlinux.org/current)
   [target] glib-devel-2.66.7_1: found (https://alpha.de.repo.voidlinux.org/current)
   [target] cairo-devel-1.16.0_2: found (https://alpha.de.repo.voidlinux.org/current)
   [target] librsvg-devel-2.50.3_1: found (https://alpha.de.repo.voidlinux.org/current)
   [target] fuse-devel-2.9.9_1: found (https://alpha.de.repo.voidlinux.org/current)
   [target] libarchive-devel-3.5.1_2: found (https://alpha.de.repo.voidlinux.org/current)
   [target] boost-devel-1.72.0_4: found (https://alpha.de.repo.voidlinux.org/current)
   [target] liblzma-devel-5.2.5_1: found (https://alpha.de.repo.voidlinux.org/current)
   [target] libcurl-devel-7.75.0_2: found (https://alpha.de.repo.voidlinux.org/current)
   [target] qt5-devel-5.15.2_4: found (https://alpha.de.repo.voidlinux.org/current)
=> AppImageLauncher-2.2.0_1: installing host dependencies: git-2.31.0_1 automake-1.16.2_2 pkg-config-0.29.2_2 libtool-2.4.6_6 wget-1.21.1_2 xxd-8.2.2513_1 desktop-file-utils-0.26_1 cmake-3.19.6_1 ninja-1.10.2_2 ...
=> AppImageLauncher-2.2.0_1: installing target dependencies: glib-devel-2.66.7_1 cairo-devel-1.16.0_2 librsvg-devel-2.50.3_1 fuse-devel-2.9.9_1 libarchive-devel-3.5.1_2 boost-devel-1.72.0_4 liblzma-devel-5.2.5_1 libcurl-devel-7.75.0_2 qt5-devel-5.15.2_4 ...
=> AppImageLauncher-2.2.0_1: running pre-build hook: 02-script-wrapper ...
=> AppImageLauncher-2.2.0_1: running do_build ...
make: *** No rule to make target 'libappimage'.  Stop.
=> ERROR: AppImageLauncher-2.2.0_1: do_build: 'make ${makejobs} libappimage libappimageupdate libappimageupdate-qt' exited with 2
=> ERROR:   in do_build() at srcpkgs/AppImageLauncher/template:26

@m4rcu5
Copy link

m4rcu5 commented Mar 24, 2021

Hi @JJGadgets, Thanks for letting me know.

It seems that the cmake build routines switched to ninja as their default generator, breaking this package. (#28304).
I've updated the package, rebased and pushed to my repository. Can you check out this commit? m4rcu5@cae1616

@JJGadgets
Copy link

@m4rcu5 Looks like you got further than I did, I was trying to add Ninja to the build process. Yours works perfectly, thanks!

Now, if it would be added to void-packages, that'd be great.

@m4rcu5
Copy link

m4rcu5 commented Mar 26, 2021

@m4rcu5 Looks like you got further than I did, I was trying to add Ninja to the build process. Yours works perfectly, thanks!

Now, if it would be added to void-packages, that'd be great.

Good to hear. I am not sure what the procedure is to get this package added, as the patch might be a bit controversial 😄

@Thomashighbaugh
Copy link

I get the controversy potential because systemd is even something the original package used to achieve its functionality and because different people will approach cmake and ninja with different opinions, solutions and want their platform to discuss why they do as they do whenever possible as is the nature of the solitary work it is to embark on the Linux journey at all (and that hardheadedness is a thing with Linux factionalism where controversy ensues where its not necessary, helpful or even about anything but an excuse for people to enumerate their feelings on a subject that in their personal life they probably know few people that would ever care to hear them discuss these things for its an unusual itch that this sort of thing is even scratching most have no notion of) but can't actually see why this would be something to incite a conflagration considering the patches here are reasonable approaches to overcoming the systemd dependency that so many others do and changes to the build process that to me, at least, are reasonable and instructive even. But its Linux and passions combine with absurd egoism in patterns the envy of the greatest dramas put to stage.

Even if its not added to void-packages @m4rcu5 please consider making a repo to make this something other's could easily add into their own void-packages repos locally as ibhagwan did with his fork of picom which you can see here as I think this would be appreciated by many and be helpful while providing everyone a workable solution no one needs to cry foul about.

Awesome work, thanks a lot and keep up the good stuff and sorry to probe this comment train rather late, I just happened to be looking for this exact solution and am grateful these are not patches falling on me to do, thought I might chime in a bit while poking at a community tendency in my ruminative way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request Package request
Projects
None yet
Development

No branches or pull requests

6 participants