Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose not to delete all pods after the job finished #129

Closed
hzxuzhonghu opened this issue May 5, 2019 · 3 comments
Closed

Propose not to delete all pods after the job finished #129

hzxuzhonghu opened this issue May 5, 2019 · 3 comments
Assignees
@TommyLike
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/high
Milestone
v0.2

Comments

@hzxuzhonghu
Copy link
Collaborator

xref: kubernetes-retired/kube-batch#797

Even job fails, the state machine would call KillJob to delete all owned resources. I think it is not acceptable for users, they need to look why it fails.
@k82cn
Copy link
Member

k82cn commented May 6, 2019

Only delete Running/Pending Pod should be ok :)

@k82cn
Copy link
Member

k82cn commented May 6, 2019

/kind feature
/priority high

@volcano-sh-bot volcano-sh-bot added kind/feature Categorizes issue or PR as related to a new feature. priority/high labels May 6, 2019
@k82cn k82cn added this to the v0.1 milestone May 6, 2019
@k82cn
Copy link
Member

k82cn commented May 8, 2019

/assign @TommyLike

@TommyLike TommyLike mentioned this issue May 9, 2019
Merged
@asifdxtreme asifdxtreme modified the milestones: v0.1, v0.2 May 13, 2019
@lminzhw lminzhw mentioned this issue May 16, 2019
Merged
@k82cn k82cn closed this as completed May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TommyLike TommyLike

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/high
Projects
None yet
Milestone
v0.2
Development

No branches or pull requests
5 participants
@TommyLike @asifdxtreme @hzxuzhonghu @k82cn @volcano-sh-bot