Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support set completions/backoffLimit to the task #1379

Closed
chenyangxueHDU opened this issue Mar 24, 2021 · 11 comments
Closed

Support set completions/backoffLimit to the task #1379

chenyangxueHDU opened this issue Mar 24, 2021 · 11 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@chenyangxueHDU
Copy link
Contributor

chenyangxueHDU commented Mar 24, 2021

What would you like to be added:

Like natvie job.Completions. As pods successfully complete, we tracks the successful completions. When a specified number of successful completions is reached, the task is complete.
Like natvie job.BackoffLimit

Why is this needed:

More flexible

@chenyangxueHDU chenyangxueHDU added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 24, 2021
@Thor-wl
Copy link
Contributor

Thor-wl commented Mar 24, 2021

That's interesting! Suggest to take it as a topic as the weekly meeting.

@chenyangxueHDU chenyangxueHDU changed the title Support set min completion to the task Support set completions/backoffLimit to the task Mar 25, 2021
@zen-xu
Copy link
Contributor

zen-xu commented Mar 25, 2021

I have implemented it in my company , users can specify minSuccess to control when job should be completed.

@Thor-wl
Copy link
Contributor

Thor-wl commented Mar 26, 2021

I have implemented it in my company , users can specify minSuccess to control when job should be completed.

Great! Do you have a plan to contribute to community?

@zen-xu
Copy link
Contributor

zen-xu commented Mar 26, 2021

/assign @zen-xu

@chenyangxueHDU
Copy link
Contributor Author

I have implemented it in my company , users can specify minSuccess to control when job should be completed.

你是港仔?

@zen-xu
Copy link
Contributor

zen-xu commented Mar 26, 2021

I have implemented it in my company , users can specify minSuccess to control when job should be completed.

你是港仔?

上海人

@chenyangxueHDU
Copy link
Contributor Author

I have implemented it in my company , users can specify minSuccess to control when job should be completed.

你是港仔?

上海人

不好意思,我有个大学同学跟你名字一样

@Thor-wl
Copy link
Contributor

Thor-wl commented Mar 26, 2021

PR: #1384

@zen-xu
Copy link
Contributor

zen-xu commented Apr 1, 2021

@chenyangxueHDU

I think you can use maxRetry, which can satisfy your BackoffLimit requirement.

// Specifies the maximum number of retries before marking this Job failed.
// Defaults to 3.
// +optional
MaxRetry int32 `json:"maxRetry,omitempty" protobuf:"bytes,8,opt,name=maxRetry"`

@stale
Copy link

stale bot commented Jun 30, 2021

Hello 👋 Looks like there was no activity on this issue for last 90 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for 60 days, this issue will be closed (we can always reopen an issue if we need!).

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 30, 2021
@stale
Copy link

stale bot commented Aug 29, 2021

Closing for now as there was no activity for last 60 days after marked as stale, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants