Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User experience improvement #335

Closed
2 of 3 tasks
TommyLike opened this issue Jul 15, 2019 · 8 comments
Closed
2 of 3 tasks

User experience improvement #335

TommyLike opened this issue Jul 15, 2019 · 8 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@TommyLike
Copy link
Contributor

TommyLike commented Jul 15, 2019

/kind feature

  • 1. Add document for volcano usecases explanation.
  • 2. Provide a convenient way for end user to install and use volcano(finished).
  • 3. Add system requirements for volcano
@hzxuzhonghu
Copy link
Collaborator

I deployed yaml generated by make generate-yaml from master.

But unfortunately, a pod failed to start.

kubectl  -n volcano-system logs volcano-admission-fd4b955cf-nsn4r 
flag provided but not defined: -webhook-namespace
Usage of /vc-admission:
  -alsologtostderr
    	log to standard error as well as files

@asifdxtreme I have an idea, we have to push the latest image every day built from the master branch. This can be done by a bot. wdyt ? cc @k82cn @TommyLike

@hzxuzhonghu
Copy link
Collaborator

cc @SrinivasChilveri we need to update volcano website

@TommyLike
Copy link
Contributor Author

I deployed yaml generated by make generate-yaml from master.

But unfortunately, a pod failed to start.

kubectl  -n volcano-system logs volcano-admission-fd4b955cf-nsn4r 
flag provided but not defined: -webhook-namespace
Usage of /vc-admission:
  -alsologtostderr
    	log to standard error as well as files

@asifdxtreme I have an idea, we have to push the latest image every day built from the master branch. This can be done by a bot. wdyt ? cc @k82cn @TommyLike

For your case @hzxuzhonghu , I think we need mention in the document. make generate-yaml will use the latest image in default. therefore he need load the latest images (maybe from local built) into his cluster. or specify the image tag when execute command:

make TAG=xxxx generate-yaml

@TommyLike
Copy link
Contributor Author

TommyLike commented Jul 17, 2019

When installing volcano v1 from chart repo, the default image tag in value file is latest. it's possible that the image would mismatch with the release yaml files. Personally I think we need update the image tag value and other necessary values when publish.
@asifdxtreme Do you mind:

  1. update the v1 zip file to use the v1 image in default , I think this is done by @thandayuthapani
  2. and if possible integrate the helm chart publish workflow into our Travis Build process Adding helm chart templates back #334?

cc @hzxuzhonghu @k82cn

@k82cn
Copy link
Member

k82cn commented Jul 17, 2019

We only need to manage released images. If using master branch, user need to build images himself; it's too heavy to mange latest images :)

@TommyLike
Copy link
Contributor Author

  1. Provide a convenient way for end user to install and use volcano.

This is done via #346

@stale
Copy link

stale bot commented Aug 18, 2020

Hello 👋 Looks like there was no activity on this issue for last 90 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for 60 days, this issue will be closed (we can always reopen an issue if we need!).

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@stale
Copy link

stale bot commented Oct 17, 2020

Closing for now as there was no activity for last 60 days after marked as stale, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants