Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm chart - remove hard coded nodeSelector for kubestatemetrics portion #3735

Open
dmildh-absci opened this issue Sep 19, 2024 · 3 comments · May be fixed by #3740
Open

helm chart - remove hard coded nodeSelector for kubestatemetrics portion #3735

dmildh-absci opened this issue Sep 19, 2024 · 3 comments · May be fixed by #3740
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@dmildh-absci
Copy link

Description

If you don't have the node label of control-plane on your cluster the metrics pod will not start. Consider making this a variable so you can provide your own node selector or provide affinity rules.

https://github.com/volcano-sh/volcano/blob/master/installer/helm/chart/volcano/templates/kubestatemetrics.yaml#L187-L190

Steps to reproduce the issue

Run the helm chart with Values.custom.metrics_enable = true

Describe the results you received and expected

The kube-state-metrics pod should start for clusters that are not using the control-plane label

What version of Volcano are you using?

volcano version: "1.5" appVersion: "0.1"

Any other relevant information

No response
@dmildh-absci dmildh-absci added the kind/bug Categorizes issue or PR as related to a bug. label Sep 19, 2024
@Monokaix
Copy link
Member

/good-first-issue

@volcano-sh-bot
Copy link
Contributor

@Monokaix:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@volcano-sh-bot volcano-sh-bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 19, 2024
@lekaf974 lekaf974 linked a pull request Sep 20, 2024 that will close this issue
Open
@lekaf974
Copy link
Contributor

@Monokaix opened this pr waiting for feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove hardcoded nodeSelector for kubestatematrics lekaf974/volcano
4 participants
@lekaf974 @Monokaix @volcano-sh-bot @dmildh-absci