Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to build release package #449

Closed
k82cn opened this issue Sep 12, 2019 · 2 comments · Fixed by #609
Closed

Failed to build release package #449

k82cn opened this issue Sep 12, 2019 · 2 comments · Fixed by #609
Labels
area/test good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@k82cn
Copy link
Member

k82cn commented Sep 12, 2019

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

Description:

There's no .git info in release package, and got following error when try to build the binaries :

~/workspace/src/volcano.sh/volcano-0.2# make
mkdir -p _output/bin
fatal: not a git repository (or any of the parent directories): .git
mkdir -p _output/release
go build -ldflags " -X 'volcano.sh/volcano/pkg/version.GitSHA=`git rev-parse HEAD`' -X 'volcano.sh/volcano/pkg/version.Built=`date "+%Y-%m-%d %H:%M:%S"`' -X 'volcano.sh/volcano/pkg/version.Version=v0.2'" -o=_output/bin/vc-scheduler ./cmd/scheduler
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
cmd/scheduler/main.go:33:2: cannot find package "volcano.sh/volcano/cmd/scheduler/app" in any of:
        /root/workspace/src/volcano.sh/volcano-0.2/vendor/volcano.sh/volcano/cmd/scheduler/app (vendor tree)
        /usr/local/go/src/volcano.sh/volcano/cmd/scheduler/app (from $GOROOT)
        /root/workspace/src/volcano.sh/volcano/cmd/scheduler/app (from $GOPATH)
cmd/scheduler/main.go:34:2: cannot find package "volcano.sh/volcano/cmd/scheduler/app/options" in any of:
        /root/workspace/src/volcano.sh/volcano-0.2/vendor/volcano.sh/volcano/cmd/scheduler/app/options (vendor tree)
        /usr/local/go/src/volcano.sh/volcano/cmd/scheduler/app/options (from $GOROOT)
        /root/workspace/src/volcano.sh/volcano/cmd/scheduler/app/options (from $GOPATH)
cmd/scheduler/main.go:37:2: cannot find package "volcano.sh/volcano/pkg/scheduler/actions" in any of:
        /root/workspace/src/volcano.sh/volcano-0.2/vendor/volcano.sh/volcano/pkg/scheduler/actions (vendor tree)
        /usr/local/go/src/volcano.sh/volcano/pkg/scheduler/actions (from $GOROOT)
        /root/workspace/src/volcano.sh/volcano/pkg/scheduler/actions (from $GOPATH)
cmd/scheduler/main.go:38:2: cannot find package "volcano.sh/volcano/pkg/scheduler/plugins" in any of:
        /root/workspace/src/volcano.sh/volcano-0.2/vendor/volcano.sh/volcano/pkg/scheduler/plugins (vendor tree)
        /usr/local/go/src/volcano.sh/volcano/pkg/scheduler/plugins (from $GOROOT)
        /root/workspace/src/volcano.sh/volcano/pkg/scheduler/plugins (from $GOPATH)
cmd/scheduler/main.go:41:2: cannot find package "volcano.sh/volcano/pkg/scheduler/util/assert" in any of:
        /root/workspace/src/volcano.sh/volcano-0.2/vendor/volcano.sh/volcano/pkg/scheduler/util/assert (vendor tree)
        /usr/local/go/src/volcano.sh/volcano/pkg/scheduler/util/assert (from $GOROOT)
        /root/workspace/src/volcano.sh/volcano/pkg/scheduler/util/assert (from $GOPATH)
Makefile:39: recipe for target 'vc-scheduler' failed
make: *** [vc-scheduler] Error 1
~/workspace/src/volcano.sh/volcano-0.2#

@volcano-sh-bot volcano-sh-bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 12, 2019
@k82cn k82cn added this to the v0.3 milestone Sep 12, 2019
@k82cn k82cn added area/test good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 12, 2019
@TommyLike
Copy link
Contributor

We may help end user to setup the correct Image Tag before executing make images command, for instance:

TAG = xxxx  make xxxxxx

But for this issue, it's because it's not a valid go root path, see:

/workspace/src/volcano.sh/volcano-0.2

@k82cn
Copy link
Member Author

k82cn commented Sep 16, 2019

I mean the following errors:

go build -ldflags " -X 'volcano.sh/volcano/pkg/version.GitSHA=`git rev-parse HEAD`' -X 'volcano.sh/volcano/pkg/version.Built=`date "+%Y-%m-%d %H:%M:%S"`' -X 'volcano.sh/volcano/pkg/version.Version=v0.2'" -o=_output/bin/vc-scheduler ./cmd/scheduler
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants