-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up E2E tests #84
Comments
One way I can think of is to run ginkgo in parallel, with And another we can do is to delete pod with grace period = 0, which can speed up job error handling. |
@hzxuzhonghu thanks, will try to evaluate this:) |
Reopen when required |
xref https://travis-ci.com/volcano-sh/volcano/jobs/198124601 |
/kind feature |
@k82cn To be honest, I think we are testing some of the advanced features which SHOULD and ALREADY been tested in kube-batch, suggest removing some of them. |
kube-batch did not include vk.job :( |
@k82cn that's true, but for some cases such as preemption, statement, gang scheduling and etc. they are all testing the features of kube-batch. If our CI can ensure
|
if we skip it, how to make sure the quality of volcano? |
@k82cn I mean kube-batch should pay attention to those testcases, not volcano. Volcano only focus on how to translate the job into pods/podgroup/etc and handling the job life cycle. For the things of how to schedule the pod group, it's the matters of kube batch. One more example, we would hardly update these cases on behalf of volcano developing. Suggestion move them into seperated folder and only valid them when releasing.
|
Volcano includes scheduler & controller, we need to make sure the quality of the whole release.
That's too late to catch issue; the release should not be block by such kind of issue. |
@k82cn We have CI for kube-batch which can ensure the quality regarding scheduling. Any changes in volcano won't break the behaviour on how to scheduling. it's only affect how the job is translated into kube-batch resource, right? |
no, refer to inqueue feature. |
Then keep this:) |
Hello 👋 Looks like there was no activity on this issue for last 90 days. |
Closing for now as there was no activity for last 60 days after marked as stale, let us know if you need this to be reopened! 🤗 |
/kind bug
Currently, Travis would spend almost 26 minutes to finish e2e tests, need to figure it out how to speed up these tests.
The text was updated successfully, but these errors were encountered: