Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh-autosuggestions work in floating window, but not in 'normal' mode / quickfix window #36

Closed
benwoodward opened this issue Feb 8, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@benwoodward
Copy link
Contributor

benwoodward commented Feb 8, 2020

Hopefully this is clear from the screenshots. When Floatterm is invoked with default floaterm_type, i.e. this global variable is not set, the terminal appears in a floating window, and suggestions from zsh-autosuggestions are visible.
image

However, if g:floaterm_type is set to 'normal', then they are not visible.
image

Another issue that is visible in these screenshots is that when the window type is set to 'normal' then the colorscheme is inherited from whatever has been set in my init.vim. However, in floating window mode the colorscheme is something else. I can create a separate issue for this if not answered here.

EDIT: Ideally I'd like a terminal in a fullscreen buffer with no borders that I can toggle with a shortcut. Is setting g:floaterm_width, and g:floaterm_height to 1 the best way to do that, or is there a better way? Do I even need this plugin to do that?

@voldikss voldikss added the bug Something isn't working label Feb 8, 2020
@voldikss
Copy link
Owner

voldikss commented Feb 8, 2020

EDIT: Ideally I'd like a terminal in a fullscreen buffer with no borders that I can toggle with a shortcut. Is setting g:floaterm_width, and g:floaterm_height to 1 the best way to do that, or is there a better way? Do I even need this plugin to do that?

You can use: terminal directly.

@benwoodward
Copy link
Contributor Author

Same issue when I use :terminal, so maybe it's not an issue with vim-floaterm?

Screen Shot 2020-02-09 at 12 24 40 pm

@voldikss
Copy link
Owner

voldikss commented Feb 9, 2020

Same issue when I use :terminal, so maybe it's not an issue with vim-floaterm?

It might be caused by the theme of your terminal app. Auto-suggestion works on my laptop when I use :terminal

Screenshot_20200209_085548

@benwoodward
Copy link
Contributor Author

benwoodward commented Feb 9, 2020

I'm putting it down to this issue: neovim/neovim#7018

EDIT: Changing zsh-autosuggestions highlight colours makes them visible. I think the highlight colour I'm using isn't visible in :terminal due to the aforementioned Neovim bug.

image

Also figured out that I just needed to set the background colour to the same as my in-built colorscheme.

Thanks for building this. Really useful.

@benwoodward
Copy link
Contributor Author

For anyone else with this issue, it's actually caused by iTerm color settings as described here: zsh-users/zsh-autosuggestions#416 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants