Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable tests for Arrow substrait compiler #195

Open
paleolimbot opened this issue Sep 8, 2022 · 0 comments
Open

Re-enable tests for Arrow substrait compiler #195

paleolimbot opened this issue Sep 8, 2022 · 0 comments

Comments

@paleolimbot
Copy link
Contributor

After #181 almost all ProjectRel plans fail with the Arrow compiler because the Emit clause isn't implemented. The PR enabling this is on the way ( apache/arrow#13914 ), but until it's merged we have too many test failures (because use select() all over the place). I tried to do this in such a way that there are test skip() and warning() wherever this happens and it shows up on the output of devtools::test(). The one place where this does not show up is the R-CMD-Check action (which commented out a bunch of arrow stuff since we don't need to build the custom version until it is reenabled in the tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant