Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify LLVM output in ptx unit tests #312

Open
vosen opened this issue Dec 13, 2024 · 2 comments
Open

Verify LLVM output in ptx unit tests #312

vosen opened this issue Dec 13, 2024 · 2 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@vosen
Copy link
Owner

vosen commented Dec 13, 2024

Expected outcome:
For each .ptx file that is unit-tested by the ptx project there is a textual LLVM output that is also verified (as a separate Rust unit tests)

Comments:

  • Last time I checked LLVM does not ship ability to compare Module objects (and implementing it ourselves would be complex due to all the details). It's sufficient to just compare strings
@vosen vosen added the help wanted Extra attention is needed label Dec 13, 2024
@JoelleJS
Copy link
Contributor

JoelleJS commented Jan 7, 2025

I'd like to have a go at this

@vosen
Copy link
Owner Author

vosen commented Jan 7, 2025

Excelellent, assigned.
If the compiled LLVM module does not match the reference then it should be printed to output. If there's the a variable set (pick a name you like) that points to a directory then it also is written to the directory.
Typical use case is that someone makes a minor change that affects a large number of tests (perhaps adding an attribute) and would like to diff all of the failed tests against reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants