Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oxygen unit #24

Open
akmazur opened this issue Dec 21, 2021 · 6 comments
Open

Oxygen unit #24

akmazur opened this issue Dec 21, 2021 · 6 comments

Comments

@akmazur
Copy link
Contributor

akmazur commented Dec 21, 2021

the current oxygen unit is umol l-1 should we change it to mmol m-3 instead to have SI units?

@akmazur
Copy link
Contributor Author

akmazur commented Dec 21, 2021

I changed the unit to mmol m-3

@callumrollo
Copy link
Member

This Issue was resolved in PR #25

@akmazur
Copy link
Contributor Author

akmazur commented Dec 22, 2021

Oxygen unit umol kg-1

@callumrollo
Copy link
Member

Is that the unit output by the optode? If not, we'll need to do some post-processing

@callumrollo
Copy link
Member

The yaml files need to represent the units of the data as they are supplied by the glider

@callumrollo callumrollo reopened this Dec 22, 2021
@akmazur
Copy link
Contributor Author

akmazur commented Dec 23, 2021

The unit from optide is umol l-1. I think we should keep mmol m-3 in the yaml. Bastien suggests that we should post-process the data to umol kg-1. Most Helcom documents show oxygen in mg l-1 or ml l-1. For easy comparison it would be nice to be consistent with them. However if I understand umol kg-1 is a standard. So I really don't know what's the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants