Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native TLS / SSL / https support (instead of relying on Nginx) #297

Closed
rickdonato opened this issue Jul 17, 2020 · 5 comments
Closed

native TLS / SSL / https support (instead of relying on Nginx) #297

rickdonato opened this issue Jul 17, 2020 · 5 comments

Comments

@rickdonato
Copy link

Is there a way to enable SSL on the Vouch Proxy. i.e Rather then just performing SSL up to NGINX and then sending it on as HTTP to Vouch?

Thanks,

@rickdonato rickdonato changed the title Vouch Proxy Enabling SSL in Vouch Proxy Jul 17, 2020
@bnfinet
Copy link
Member

bnfinet commented Jul 22, 2020

@rickdonato there is no direct TLS/SSL/https support in VP at this time, however it shouldn't be too hard to add to VP with some minor modifications to main.go and cfg.go

This looks like a nice setup to mimic....
https://github.com/denji/golang-tls#perfect-ssl-labs-score-with-go

I'd suggest new config params vouch.tls.cert and vouch.tls.key

@rickdonato do let me know if this is something you'd be interested in working on

@bnfinet bnfinet changed the title Enabling SSL in Vouch Proxy native TLS / SSL / https support (instead of relying on Nginx) Jul 22, 2020
@rickdonato
Copy link
Author

Thanks. Unfortunately, as it stands I've not developed in Go.

@bnfinet
Copy link
Member

bnfinet commented Nov 17, 2020

@danfaizer thanks so much for the contribution!

Could you please add

  • test coverage
  • a check in cfg.basicTest that if vouch.tls.cert or vouch.tls.key is set, then so is the other one
  • modification of startup log messages related to indicate that TLS is enabled and that VP is available at https://0.0.0.0:9090
  • a new block in the README mentioning TLS config

I'll add a few quick notes to the PR for a couple things as well

FYI - I'm not quite in a position to look closely at outstanding PRs and merge, hopefully just a few more days here

@bnfinet
Copy link
Member

bnfinet commented Nov 17, 2020

@danfaizer ^^

@bnfinet
Copy link
Member

bnfinet commented Dec 8, 2020

@danfaizer excellent stuff. Thanks again for the contribution.

@bnfinet bnfinet closed this as completed Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants