Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base art pack no longer available on dropbox #17

Open
Ithamar opened this issue Oct 15, 2018 · 1 comment
Open

base art pack no longer available on dropbox #17

Ithamar opened this issue Oct 15, 2018 · 1 comment

Comments

@Ithamar
Copy link

Ithamar commented Oct 15, 2018

The included URL to dropbox for the default artpack is no longer working. This also breaks the voxel-example, since that's using the default artpack.

Tried using
https://github.com/deathcap/ProgrammerArt/releases/download/v3.0/ProgrammerArt-v3.0-ResourcePack-MC19.zip but that has CORS issues :(

@deathcap
Copy link
Member

deathcap commented Jan 6, 2021

Updated to GitHub URL in #16

To avoid the CORS issues, one can bundle the zip in the project and override the artpacks URL to a local path, such as in the (updated) voxel-example: voxel/voxel-example@6c34f67 (and how I was doing already in voxelmetaverse: https://github.com/voxel/voxelmetaverse/blob/98ade91bafe4a1a4e612fca2cf8169d6545003a5/index.js#L112-L114):

    'voxel-stitch': {
      artpacks: ['ProgrammerArt-ResourcePack.zip']
    },

Having an external reference to these assets wasn't the best idea, in retrospect, but I'm not sure of a good way to embed them in this library... (hardcode the zip in JS?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants