Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run configtest before reloading service #338

Closed
nvtkaszpir opened this issue May 18, 2017 · 2 comments
Closed

Run configtest before reloading service #338

nvtkaszpir opened this issue May 18, 2017 · 2 comments

Comments

@nvtkaszpir
Copy link
Contributor

nvtkaszpir commented May 18, 2017

Puppet should run config test prior restarting service:

consul configtest -config-dir ...

Currently config_hash can get any key/value which can be not understood by consul, thus failing to start service.

@solarkennedy
Copy link
Contributor

That would be cool. Now we could do that at the init script level because we control all of them:
https://github.com/solarkennedy/puppet-consul/tree/master/templates

I don't know if all init types are amenable to that though.

If we wanted to do it with a puppet exec, I think we would want to use something like this:
https://github.com/puppetlabs/puppetlabs-transition

To be able to run that exec before the service is restarted.

Or we could just put it in
https://github.com/solarkennedy/puppet-consul/blob/master/manifests/reload_service.pp

We would just need to make sure that properly notifies the service below.

@solarkennedy
Copy link
Contributor

We tried this, and it didn't work so great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants