Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency towards concat module #60

Closed
Yyuzu opened this issue Dec 15, 2017 · 3 comments
Closed

Update dependency towards concat module #60

Yyuzu opened this issue Dec 15, 2017 · 3 comments

Comments

@Yyuzu
Copy link
Contributor

Yyuzu commented Dec 15, 2017

Hi,

I'm currently using puppet with concat module version v4.1.1 (github master) and I'm getting this notice in puppet master:

Warning: Module 'puppetlabs-concat' (v4.1.1) fails to meet some dependencies:
'puppet-drbd' (v0.5.1-rc0) requires 'puppetlabs-concat' (>= 1.2.5 < 3.0.0)

If I use concat version 2.2.1 (latest version < 3.0.0) I get a lot of dependencies errors from other modules. I think you could increase required concat module version to a more recent one. I suppose you have tests to check it's ok, but on my side, no problem with concat v4.1.1.

Cheers !
Kyoshiro

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 4.8.2-5~bpo8+1
  • Ruby: 2.1.5+deb8u2
  • Distribution: Debian Jessie (backports)
  • Module version: 0.5.1-rc0 (guthub master)
@ekohl
Copy link
Member

ekohl commented Dec 17, 2017

We encourage submitting a PR to change metadata.json to allow that version. Would you be willing to submit a PR?

@Yyuzu
Copy link
Contributor Author

Yyuzu commented Dec 17, 2017

Hi,

No worries, I'll open a PR, although I must say I haven't checked all features.
I'll open a PR now with my version as latest allowed version, feel free to change it to whatever version you see fit !

Cheers

@Yyuzu
Copy link
Contributor Author

Yyuzu commented Dec 19, 2017

Cheers !
Keep up the good work :-)

@Yyuzu Yyuzu closed this as completed Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants