Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README has invalid 'family' => 'ipv6' example for firewalld_ipset options. #231

Closed
Phurion opened this issue Oct 16, 2019 · 3 comments
Closed

README has invalid 'family' => 'ipv6' example for firewalld_ipset options. #231

Phurion opened this issue Oct 16, 2019 · 3 comments

Comments

@Phurion
Copy link
Contributor

Phurion commented Oct 16, 2019

When making an IPset, in the readme file it says to use "ipv6" for IPv6 addresses

{ "family" => "ipv6" } when it should be
{ "family" => "inet6" } unless this module should be changing ipv6 to inet6 in the background

firewall-cmd won't accept ipv6

firewall-cmd --version
0.6.3

CentOS Linux release 8.0.1905
@alexjfisher
Copy link
Member

@Phurion Good spot. Would you be able to open a PR to fix the README?

@Phurion
Copy link
Contributor Author

Phurion commented Oct 18, 2019

Sure I'll try to get one uploaded today

@Phurion
Copy link
Contributor Author

Phurion commented Oct 18, 2019

Submitted PR

@Phurion Phurion closed this as completed Oct 18, 2019
@alexjfisher alexjfisher changed the title IPset readme for ipv6 README has invalid 'family' => 'ipv6' example for firewalld_ipset options. Oct 22, 2019
@alexjfisher alexjfisher mentioned this issue Oct 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexjfisher @Phurion