Broken LDAP

[karolisc]

Hi,

42ff18e commit has broke LDAP configuration.

I do not see any major changes in omnibus LDAP configuration:

1. https://gitlab.com/gitlab-org/omnibus-gitlab/blob/master/files/gitlab-config-template/gitlab.rb.template#L152-208
2. https://docs.gitlab.com/ce/administration/auth/ldap.html

@davidgubler Why have you decided it is broken? it was working for me.

Karolis

[davidgubler]

Hi Karolis,

I had to change this because the previous version broke the encoding of some strings (certain LDAP passwords did not work due to this). I don't remember which characters where affected, though.

I guess it is not impossible that you need to change the encoding of certain characters in your configuration because of this (depending on the concrete values).

There is also some related discussion in #92.

[karolisc]

Hi @davidgubler ,

Thank you for the reference.

I have tested version 1.13.3 and it seems it is working as expected. Module does add correct key = value/array pair in /var/opt/gitlab/gitlab-rails/etc/gitlab.yml.

Although I think probably some note should be added to the Documentation as LDAP configurtation differs a lot from the Omnibus official one.

Karolis

[juniorsysadmin]

Closing due to age.