Regression: yum $releasever results in 404 error for RHEL yum repo

[esalberg]

This commit, which changes ${releasever} (set to 5/6/7 for RHEL) to $releasever (uses the yum releasever) does not work for us on RHEL6. The yum $releasever is 6Server, and the actual gitlab URL needs just 6.
1192cc6

This was previously noted and fixed / working fine, e.g. as seen in this issue:
#42

I'm happy to put in a PR (I forked the module anyway so that I could get my upgrade to proceed), but I wanted to put in an issue first to get confirmation.

[esalberg]

Also, since the old code used is_hash, and that is deprecated, would you prefer:

1. ignore $::os[release][major] and just use $::operatingsystemrelease
2. use validate_legacy (but that only supports Puppet 4.4.x+, so may be too version restricting)
3. replace it another way?

Code in question:
if is_hash($::os) {
$releasever = $::os[release][major]
} else {
$releasever = $::operatingsystemmajrelease
}

[Poil]

+1

[jsmelser]

I am getting this on redhat 7 as well.

[TJuberg]

I can confirm that this issue is affecting us on Redhat Enterprise Linux 7 as well

[mhyzon]

I created #172 which fixes this issue (again, I guess?) and also adds the proper GPG key for EE if you are using EE and enables RPM verification.

[pebtron]

I can also confirm that on RHEL7 the URL https://packages.gitlab.com/gitlab/gitlab-ce/el/7Server/x86_64/repodata/repomd.xml 404's. The correct URL should be https://packages.gitlab.com/gitlab/gitlab-ce/el/7/x86_64/repodata/repomd.xml.

[juniorsysadmin]

Fixed by #172 I think