Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.1.1 should be 3.0.0 #236

Closed
roidelapluie opened this issue May 27, 2018 · 2 comments
Closed

2.1.1 should be 3.0.0 #236

roidelapluie opened this issue May 27, 2018 · 2 comments

Comments

@roidelapluie
Copy link
Member

I am concerned that it is a 2.x release while the version in the meadata.json stqted 3.0.0.

Why is that? Looks like some types have changed.
@LongLiveCHIEF
Copy link
Contributor

It's correct as is. I originally wasn't going to add a deprecation for skip_auto_migrations, and just entirely remove it. However, I decided it was best to leave it in there so that we could continue to support older versions of gitlab, and I just added a deprecation notice in the client catalog output.

As a result of this, there were no breaking changes, so I incremented the minor version instead of the major version. (I forgot to drop the version in my original PR after adding the deprecation, so that PR was accepted with the metadata.json 3.0.0-rc0 version).

@roidelapluie
Copy link
Member Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roidelapluie @LongLiveCHIEF