Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puppet-grafana Debian repository should use codename stretch #112

Closed
drshawnkwang opened this issue Jun 18, 2018 · 4 comments · Fixed by #113
Closed

puppet-grafana Debian repository should use codename stretch #112

drshawnkwang opened this issue Jun 18, 2018 · 4 comments · Fixed by #113

Comments

@drshawnkwang
Copy link

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 5.5.3
  • Ruby: 2.9.4
  • Distribution: Deiban Stretch
  • Module version: 4.2.0

How to reproduce (e.g Puppet code you use)

Simply run and the code and install grafana, specifically the grafana repository list.

What are you seeing

File '/etc/apt/sources.list.d/grafana.list' contains line
deb https://packagecloud.io/grafana/stable/debian jessie main

What behaviour did you expect instead

File should contain line
deb https://packagecloud.io/grafana/stable/debian stretch main

Output log

n/a

Any additional information you'd like to impart

Grafana upstream documentation says to use release codename 'stretch'. http://docs.grafana.org/installation/debian/

This is very similar to PR #41.

@drshawnkwang drshawnkwang changed the title Grafana Debian repository should use codename stretch puppet-grafana Debian repository should use codename stretch Jun 18, 2018
@bastelfreak
Copy link
Member

Hi @drshawnkwang, thanks for bringing this up. Are you able to provide a PR for this?

@drshawnkwang
Copy link
Author

drshawnkwang commented Jun 18, 2018

I created a branch and tested it on Debian 9 stretch, but did not do so on any other OS. If I created a PR, could someone test it on other OSes to verify that changing the release doesn't break anything else?

@bastelfreak
Copy link
Member

Just open up the PR, we can write an acceptance test for it.

@drshawnkwang
Copy link
Author

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants