Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept SHA256 fingerprints (since Icinga2 2.12.0) #631

Closed
thorstenk opened this issue Oct 2, 2020 · 0 comments · Fixed by #632
Closed

Accept SHA256 fingerprints (since Icinga2 2.12.0) #631

thorstenk opened this issue Oct 2, 2020 · 0 comments · Fixed by #632

Comments

@thorstenk
Copy link
Contributor

icinga2 pki save-cert was changed to use SHA256 digest with version 2.12.0 (see commit Icinga/icinga2@a91b9f2d#diff-6b6e5e369dd1e12a3d39c9fccfa7ee01R361).

Expected Behavior

Class icinga2::feature::api accepts attribute fingerprint in SHA1 and SHA256 format.

Current Behavior

Class icinga2::feature::api requires attribute fingerprint to be in SHA1 format.

Possible Solution

change RegEx in definition of type Icinga2::Fingerprint

Additional thoughts:

How could / should users be notified to update the fingerprint in their (presumably) Hiera data?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accepts SHA1 and SHA256 fingerprint digests thorstenk/puppet-icinga2
1 participant
@thorstenk