-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jira service not restarted when changing systemd file #315
Comments
I think we should use ˋˋˋcamptocamp/systemdˋˋˋ. @bastelfreak Do you agree? |
I know you're not asking me, but will point out that it would be consistent with the Vox Pupuli Confluence module to do that... |
Sounds good. It looks like the Confluence module is a little bit smarter, because it does not restart by default. Are you able to provide a pull request? That would be great. |
I'm willing to do a PR (are several PRs?). Upon code review, there are some organizational issues that I think would help when doing so. My questions would be:
Of less interest, but will point out that I am willing to address while I working:
|
I'm currently on a cleanup spree, so it's pretty likely I'll do something to fix this too until I run out of steam :P Let's see. |
Affected Puppet, Ruby, OS and module versions/distributions
How to reproduce (e.g Puppet code you use)
Change
$javahome
What are you seeing
I believe https://github.com/voxpupuli/puppet-jira/blob/master/manifests/service.pp#L41 should be
notify
, notbefore
.What behaviour did you expect instead
Change in JAVA_HOME env var should restart the service, not just refresh systemd.
Output log
Ran
service jira status -l
and found that the service was still running the old version of Java 8.Any additional information you'd like to impart
Am converting from Oracle JDK to AdoptOpenJDK JRE and the JIRA service needed to be manually restarted. I think this can be avoided with a simple metaparameter change.
The text was updated successfully, but these errors were encountered: