Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puppet-lint-strict_indent-check --fix makes it worse instead of better #33

Open
shibumi opened this issue Apr 18, 2023 · 0 comments
Open

Comments

@shibumi
Copy link

shibumi commented Apr 18, 2023

Hi,

We have the following code:

  file { ['/opt/foo/var',
          '/opt/foo/log',
          '/opt/foo/bar']:
    ensure => directory,
    owner  => 'root',
    group  => 'root',
    mode   => '0755',
  }

The formatter makes out of this perfectly fine code something like this:

  file { ['/opt/dbe/dirtdb',
      '/opt/dbe/log',
    '/opt/dbe/sox']:
      ensure => directory,
      owner  => 'root',
      group  => 'root',
      mode   => '0755',
  }

This is not the only occurence. Looks like the formatter is formatting code incorrectly in several other places as well.
For example in one occurence it made out of a file:

class bar::foo {
...
exec { 'foobarbazinga':
    command => '/usr/sbin/command',
    unless  => '/usr/sbin/command2',
  }
}

Something like this:

class bar::foo {
...
exec { 'foobarbazinga':
    command => '/usr/sbin/command',
    unless  => '/usr/sbin/command2',
} }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant