Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate default JVM options #343

Open
LionelCons opened this issue May 31, 2017 · 1 comment
Open

Duplicate default JVM options #343

LionelCons opened this issue May 31, 2017 · 1 comment

Comments

@LionelCons
Copy link

service.pp contains default JVM options in $default_jvm_options but they don't seem to be used.

Instead, defaults are hard-coded in jvm.options.erb.

Defaults should be defined only once.

@martin-koerner
Copy link

Additionally, the defaults (-Xms=256m -Xmx1g) don't match the docs: "Always make sure to set the minimum (Xms) and maximum (Xmx) heap allocation size to the same value to prevent the heap from resizing at runtime, which is a very costly process. " (https://www.elastic.co/guide/en/logstash/current/performance-troubleshooting.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants