php module is not using hiera deep merge anymore.

[schlitzered]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 5
• Ruby: ???
• Distribution:???
• Module version: 6.0.2

How to reproduce (e.g Puppet code you use)

use hiera to configure php::extensions

What are you seeing

hiera is not deep merging anymore

What behaviour did you expect instead

hiera should deep merge php:extensions, as well as for all other lookups

Output log

Any additional information you'd like to impart

the relevant pull request is this one: commit

this basically makes merging using hiera impossible, please revert this as soon as possible or explain

[c33s]

this works as intended. with the PR i made the "double lookup" was fixed. puppet looks-up class parameter per default. so having the parameter looked up by puppet and then do a manual lookup overwrites the merge behavior which you can define in your common.yaml (or another hiera yaml file).

having the module work like this you can define the lookup variant you want. simply add:

lookup_options:
    php::extensions: { merge: {strategy: deep, merge_hash_arrays: true, knockout_prefix: "--", sort_merged_arrays: true}}

but you can also choose to use a different merge behavior. this was not possible before

have a look at #434

[schlitzered]

it is a little bit unfortunate that this change has not made it into the changelog :-/

i will adjust my hiera yaml to include the lookup_options you suggested.

[arkadicolson]

I'm still having the issue that php::settings is not merged into php::fpm::settings
Any idea why? In 4.0.0 this was working...