Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres_exporter 0.10.0 cannot be downloaded #584

Closed
reini-1 opened this issue Oct 1, 2021 · 5 comments · Fixed by #591
Closed

postgres_exporter 0.10.0 cannot be downloaded #584

reini-1 opened this issue Oct 1, 2021 · 5 comments · Fixed by #591

Comments

@reini-1
Copy link

reini-1 commented Oct 1, 2021

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 6.24.0
  • Ruby:
  • Distribution: Debian
  • Module version: latest 12.1.1

How to reproduce (e.g Puppet code you use)

Set version of postgres_exporter to 0.10.0

What are you seeing

The latest version of postgres_exporter cannot be downloaded as the url has changed.

https://github.com/wrouesnel/postgres_exporter/releases/download/v0.10.0/postgres_exporter_v0.10.0_linux-amd64.tar.gz
vs.
https://github.com/prometheus-community/postgres_exporter/releases/download/v0.10.0/postgres_exporter-0.10.0.linux-amd64.tar.gz

It is now in the prometheus-community repo, "v" before version in filename is gone, "_" (underline) before version is now "-" (dash) and "_" (underline) after version is now a "." (dot).

I think download_url_base in data/defaults.yaml and $real_download_url in manifests/postgres_exporter.pp must be changed.

Maybe a distinction between old versions an new (0.9.0+) is necessary.

What behaviour did you expect instead

The new version should be downloaded.

Output log

Error: Execution of '/usr/bin/curl https://github.com/wrouesnel/postgres_exporter/releases/download/v0.10.0/postgres_exporter_v0.10.0_linux-amd64.tar.gz -o /tmp/postgres_exporter-0.
10.0.tar.gz_20211001-24770-xvlo91 -fsSLg --max-redirs 5' returned 22: curl: (22) The requested URL returned error: 404
Error: /Stage[main]/Prometheus::Postgres_exporter/Archive[/tmp/postgres_exporter-0.10.0.tar.gz]/ensure: change from 'absent' to 'present' failed: Execution of '/usr/bin/curl https:/
/github.com/wrouesnel/postgres_exporter/releases/download/v0.10.0/postgres_exporter_v0.10.0_linux-amd64.tar.gz -o /tmp/postgres_exporter-0.10.0.tar.gz_20211001-24770-xvlo91 -fsSLg -
-max-redirs 5' returned 22: curl: (22) The requested URL returned error: 404
Notice: /Stage[main]/Prometheus::Postgres_exporter/File[/usr/local/bin/postgres_exporter]: Dependency Archive[/tmp/postgres_exporter-0.10.0.tar.gz] has failures: true
Warning: /Stage[main]/Prometheus::Postgres_exporter/File[/usr/local/bin/postgres_exporter]: Skipping because of failed dependencies
Warning: /Stage[main]/Prometheus::Postgres_exporter/Prometheus::Daemon[postgres_exporter]/Group[postgres-exporter]: Skipping because of failed dependencies
Warning: /Stage[main]/Prometheus::Postgres_exporter/Prometheus::Daemon[postgres_exporter]/User[postgres-exporter]: Skipping because of failed dependencies
Warning: /Stage[main]/Aida::Postgresql::Postgres_exporter/File[/etc/postgres_exporter]: Skipping because of failed dependencies
Warning: /Stage[main]/Aida::Postgresql::Postgres_exporter/File[/etc/postgres_exporter/queries.yaml]: Skipping because of failed dependencies
Warning: /Stage[main]/Prometheus::Postgres_exporter/Prometheus::Daemon[postgres_exporter]/File[/etc/default/postgres_exporter]: Skipping because of failed dependencies
Warning: /Stage[main]/Prometheus::Postgres_exporter/Prometheus::Daemon[postgres_exporter]/Systemd::Unit_file[postgres_exporter.service]/File[/etc/systemd/system/postgres_exporter.se
rvice]: Skipping because of failed dependencies
Warning: /Stage[main]/Prometheus::Postgres_exporter/Prometheus::Daemon[postgres_exporter]/Service[postgres_exporter]: Skipping because of failed dependencies

Any additional information you'd like to impart

@donjuanmon
Copy link

donjuanmon commented Oct 14, 2021

Had same problem, defining this worked for download:

class { 'prometheus::postgres_exporter':
  download_url    => 'https://github.com/prometheus-community/postgres_exporter/releases/download/v0.10.0/postgres_exporter-0.10.0.linux-amd64.tar.gz',
  version         => '0.10.0',
}

@reini-1
Copy link
Author

reini-1 commented Oct 22, 2021

any progress on this?

@reini-1
Copy link
Author

reini-1 commented Nov 4, 2021

any thing new here?

@smortex
Copy link
Member

smortex commented Nov 4, 2021

Have you considered opening a Pull Request (PR) to add your change 😉? This look like a perfect enhancement for a first-time contributor!

If you do not know how to start, here is a quite complete guide about the process of contributing to projects on GitHub:
https://dataschool.io/how-to-contribute-on-github

In any case, do not feel scared: we are here to help!

@reini-1
Copy link
Author

reini-1 commented Nov 5, 2021

I will try ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants