Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling Proxysql Conf Generation makes module fail #166

Open
rushi47 opened this issue May 24, 2021 · 0 comments
Open

Disabling Proxysql Conf Generation makes module fail #166

rushi47 opened this issue May 24, 2021 · 0 comments

Comments

@rushi47
Copy link

rushi47 commented May 24, 2021

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet:5.5.22
  • Ruby:
  • Distribution:
  • Module version: 5.0.0

How to reproduce (e.g Puppet code you use)

proxysql::manage_config_file: false

What are you seeing

After setting this value to false, i expect that it should not manage my conf file.
But it looks like that
proxysql::reload_config class checks for the resource :

File['proxysql-config-file']
@
https://github.com/voxpupuli/puppet-proxysql/blob/master/manifests/reload_config.pp#L5-L7

Now this resource is created @
https://github.com/voxpupuli/puppet-proxysql/blob/master/manifests/config.pp#L10-L18
in turn which requires variable proxysql::manage_config_file: false to true.

Which sounds like dead lock to me if i interpret correctly.

What behaviour did you expect instead

If i set proxysql::manage_config_file: false
i think subscriber value should be avoided or it should be able to look up file $proxysql::mycnf_file_name
for this variable
https://github.com/voxpupuli/puppet-proxysql/blob/master/manifests/reload_config.pp#L10

Output log

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Could not find resource 'File[proxysql-config-file]' in parameter 'subscribe' (file: /etc/puppetlabs/code/environments/tets/modules/proxysql/manifests/reload_config.pp, line: 22) on node proxysql-test01

Any additional information you'd like to impart

Am not sure if this is correct solution but considering subscribe only if
proxysql::manage_config_file is set to true else avoiding completley.
Or if we can achieve look up on file set via this variable : $proxysql::mycnf_file_name
should help.
OR we can disable the whole class reload_config if proxysql::manage_config_file set to false (could be dirty solution)

Let me know if am pursuing this incorrectly and i need to set some other variables to achieve this.

Will be waiting for the reply.

Thanks a lot in advance .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant