Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency disappeared from forge. #116

Closed
AlexRRR opened this issue Jan 16, 2015 · 5 comments
Closed

Dependency disappeared from forge. #116

AlexRRR opened this issue Jan 16, 2015 · 5 comments

Comments

@AlexRRR
Copy link

AlexRRR commented Jan 16, 2015

Hello! Thanks for your module I've been using it for a while now. Just a heads up for everyone... it seems that the dependency on "mhuffnagle/make" has disappeared from puppetforge

https://forge.puppetlabs.com/mhuffnagle/make returns 404

I know they have been fiddling with adding ratings to the modules and what not, but r10k complains loudly now about this not working.

Cheers,

@AlexRRR
Copy link
Author

AlexRRR commented Jan 16, 2015

Oh.. it is also gone from github.

@ghoneycutt
Copy link
Member

https://github.com/ghoneycutt/puppet-modules/blob/master/Puppetfile#L59-63

I'm using Element84/puppet-make with a specific commit hash in my Puppetfile to resolve this dependency. @AlexRRR this could be a short term fix for you.

@acidprime was going to suggest using that one in your Modulefile, but it appears to be abandoned, only supports EL and Ubuntu, and the tests don't actually test the functionality.

I could put together a module for it, though first do you know of any that already exist? Could not find anything on the forge.

@acidprime
Copy link
Collaborator

@acidprime
Copy link
Collaborator

I will likely remove this as a dep in 3.x series of the module as make is not required in v1 of r10k any more and its probably been long enough now

@ghoneycutt
Copy link
Member

Awesome! I can remove a few dependencies in my Puppetfile that are just for r10k :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants