r10k.yaml is rebuilt (md5sum differs) every Puppet run on ruby 1.8.7

[brasey]

Looks like the contents of r10k.sources are just printing out in random order. One Puppet run will put sources: before basedir:, and the next will reverse it.

Would sorting the hash first keep this from happening?

[acidprime]

I am assuming you are on ruby 1.8.7?

[brasey]

It is:
$ ruby -v
ruby 1.8.7 (2011-06-30 patchlevel 352) [x86_64-linux]

Time to upgrade?

[Sharpie]

In Ruby 1.8.7, the order of hash contents is not deterministic and may change between runs --- this results in YAML output with different orderings. In Ruby 1.9.3 and newer, hashes are deterministic with respect to the order in which keys are added to the hash.

[brasey]

Thanks for the explanation.

[Sharpie]

And to actually answer your original question: yes, sorting the hash prior to output should ensure a fixed order.

[ghoneycutt]

@acidprime This affects EL 6 which uses ruby v1.8.7. Since this module supports ruby v1.8.7 could you please take a look at this?

[tfhartmann]

👍

[Sharpie]

Given that PE 3 runs on Ruby 1.9.3, getting this fixed on 1.8.x might have to fight its way up the TODO list. Anyone feel like submitting a pull request?

[tfhartmann]

I'd be willing to take a swing at it..

[ghoneycutt]

@tfhartmann you're my hero

[acidprime]

closing , will reopen if #44 causes issues