Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't pin sinatra and webrick gems anymore #471

Closed
kenyon opened this issue Dec 5, 2018 · 1 comment
Closed

don't pin sinatra and webrick gems anymore #471

kenyon opened this issue Dec 5, 2018 · 1 comment

Comments

@kenyon
Copy link
Member

kenyon commented Dec 5, 2018

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 6.0
  • Distribution: Debian 9.6
  • Module version: master

What are you seeing

Now that WEBrick is in the Ruby standard library, and Puppet Platform 6.0 packages include Ruby 2.5.1, we shouldn't need to pin the webrick and sinatra versions anymore. So I believe these commits could just be reverted:

@kenyon
Copy link
Member Author

kenyon commented Dec 5, 2018

Alternatively, setting the defaults for r10k::webhook::package::sinatra_version and r10k::webhook::package::webrick_version to 'installed' would work too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant