Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix versionlock regex #35

Closed
lamawithonel opened this issue Jan 20, 2017 · 1 comment
Closed

Fix versionlock regex #35

lamawithonel opened this issue Jan 20, 2017 · 1 comment

Comments

@lamawithonel
Copy link

The current regular expressions for the yum::versionlock defined type are too liberal and will match invalid strings as long as they end in an asterisk. In my experience, although the official documentation is a little vague on this, wildcard characters cannot cover the field separators. For example, 0:bash-4.1.2-9.el6_2.*, the example from the header docs, is valid, because it uses the wildcard to cover the %{ARCH} field. However, this seemingly similar input would be invalid to yum-versionlock (but valid to the module): 0:bash-4.1.2-9*.

Fixing this will be a breaking change, so I wanted to open this before it gets tagged 1.0.0. I am working on a fix.

@vinzent
Copy link

vinzent commented Jan 20, 2017

it's too my expirience that the asterisk only works for a single field and documentation is not very good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants