-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zabbix::userparameters source & script, remove "Stdlib::Filesource" type #580
Comments
Hi @sfuerte, thanks for bringing this up. Are you able to provide a PR for this module to fix this? |
@bastelfreak PR to stdlib needed probably? |
That would be the longterm fix, yes. But I don't expect that we get fast releases for stdlib. |
@bastelfreak A temporary fix in this module would make sense. Meanwhile, I've opened puppetlabs/puppetlabs-stdlib#981 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Not sure why it was introduced in 95dc9b21, but it limits the usage significantly, as the path can be only:
(see https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/types/filesource.pp)
The issue arises when there is a specific mount points (as per https://puppet.com/docs/puppet/6.1/file_serving.html) in Puppet, e.g. /etc/puppetlabs/puppet/fileserver.conf:
Then I can access it with simple
puppet:///my_storage/...
, for example (in Hiera):Benefits of such approach:
Stdlib::HTTPUrl
)puppet:///modules/zabbix/...
would work but then it's a hassle to upgrade the module every single time)PS: though raised a FR for Stdlib as well, https://tickets.puppetlabs.com/browse/MODULES-8404
The text was updated successfully, but these errors were encountered: