Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial #1 general comments #16

Open
rdgao opened this issue Nov 20, 2018 · 2 comments
Open

Tutorial #1 general comments #16

rdgao opened this issue Nov 20, 2018 · 2 comments

Comments

@rdgao
Copy link

rdgao commented Nov 20, 2018

  • sampling and aliasing should not be capitalized, they're regular words.
  • on sampling: "We sample because there is a cost to data which is memory." This is not quite right technically. Sampling is how we convert a continuous-time (analog) signal to a discrete-time (digital) signal that can be saved on a digital computer, such as your laptop. There is no way to save an analog signal, like scalp voltage from EEG, on a modern computer. We DOWNSAMPLE because there is a cost to saving data.
  • a more detailed explanation of the relationship between higher sampling rate and high-frequency content may be useful.
  • clarify in the "generate time axis" section that sampling rate is always determined by the acquisition system, especially since we're using real data in this first part (which means it came with a sampling rate), so we don't have people going away thinking you can just arbitrarily "set" a sampling rate. It's a fundamental property of the dataset (metadata).

under analyzing our graph:

  • rythmic is a typo.
  • not sure why we need to put the canonical band examples here. I can see it being a "negative example", in which case we should add a quick one-liner about how these oscillations may not be bandlimited.
  • grounding and referencing can be a whole new notebook/tutorial, because it's a quite extensive topic and there are a variety of ways to do it.
@rdgao rdgao changed the title Tutorial 1 comments/edits Tutorial #1 comments/edits Nov 20, 2018
@rdgao rdgao changed the title Tutorial #1 comments/edits Tutorial #1 general comments Nov 20, 2018
@lakimenon
Copy link

Under Part 2: Ground vs. Referencing:

  • The second link is in parentheses?
  • There isn't a space after "(electroencephalogram)" (very minor error but it was bothering me sorry)
  • movement is misspelled as mouvement
  • The last paragraph starts with open quotations which need to be either closed or removed
  • "summed ears" is mentioned but there's no explanation of what that means

@meyhaa
Copy link

meyhaa commented May 7, 2019

  • Introduction
    • Include an explanation of what an electrophysiological time series is before going into the purpose of the tutorial (reference tutorial 3’s introduction to power spectral density)
  • Loading the data with npy file
    • It is mentioned that the data is a voltage series. Is that a key term that needs to be elaborated on in order to understand the type of data this tutorial is used for?
  • Sampling & Aliasing
    • PSD is introduced for the first time as an acronym. Please change to power spectral density
    • Figure 1: Altitude of a Plane —> difficult to see the grey line in order to understand the pattern of how different the grey line is from the 4 colorful lines
    • Needs more bolded terms/phrases (reference bolded terms in tutorial 3)

Potential Key Terms for Glossary (extensive list for you to narrow down/edit):
Voltage Series?
Sampling Rate
Oversample
Undersampling
Digital Signal Processing
Temporal Resolution
Time Series
Rhythmic patterns
Grounding
Referencing
EEG
Active Electrode
Reference Electrode
Electrical Potential Differences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants