Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure URLs in references are linked properly #275

Closed
purva-thakre opened this issue Nov 23, 2023 · 5 comments · Fixed by #827
Closed

Make sure URLs in references are linked properly #275

purva-thakre opened this issue Nov 23, 2023 · 5 comments · Fixed by #827
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers non-quantum
Milestone

Comments

@purva-thakre
Copy link
Collaborator

purva-thakre commented Nov 23, 2023

After changes introduced in #228, make sure all links in articles.bib show up correctly as links. Currently, some of the URLs are strings because pybtex was unable to parse "\url{some_link}" correctly.

The goal of this issue is to figure out what format works for URLs in sphinxcontrib-bibtex and is also compatible with pybtex. Then, apply those changes to most of the @misc refs in articles.bib.

@purva-thakre purva-thakre changed the title Make sure urls in references are linked properly Make sure URLs in references are linked properly Nov 23, 2023
@purva-thakre purva-thakre added the documentation Improvements or additions to documentation label Nov 23, 2023
@vprusso
Copy link
Owner

vprusso commented Oct 4, 2024

Is this still an issue? If so, are there specific links that are rendering in this way as an example? ( @purva-thakre )

@purva-thakre
Copy link
Collaborator Author

@vprusso Yes, this is still relevant. I don't think this is high priority though.

Some links on the references page of the docs are not clickable. For example, all the Wikipedia links:

image

@vprusso
Copy link
Owner

vprusso commented Oct 4, 2024

Ah, okay. I think I know why. It looks like the url entry in the refs.bib file is empty. I'll go ahead and make a fix for this. Thanks for the clarification!

@purva-thakre
Copy link
Collaborator Author

The url entry is empty because it would lead to build errors.

See #228 (comment)

@vprusso
Copy link
Owner

vprusso commented Oct 4, 2024

So far so good:
#827

I'll keep adding the references and hope that nothing breaks :P

@purva-thakre purva-thakre added this to the v1.1.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers non-quantum
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants