Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elasticsearch QueryType "should" missing #58

Closed
lunarie16 opened this issue Jan 11, 2021 · 1 comment
Closed

Elasticsearch QueryType "should" missing #58

lunarie16 opened this issue Jan 11, 2021 · 1 comment

Comments

@lunarie16
Copy link
Contributor

fake elasticsearch misses logical OR as "should" QueryType.

File "/opt/hostedtoolcache/Python/3.7.9/x64/lib/python3.7/site-packages/elasticmock/fake_elasticsearch.py", line 108, in _evaluate_for_compound_query_type

QueryType.get_query_type(query_type),

File "/opt/hostedtoolcache/Python/3.7.9/x64/lib/python3.7/site-packages/elasticmock/fake_elasticsearch.py", line 48, in get_query_type

raise NotImplementedError(f'type {type_str} is not implemented for QueryType')

NotImplementedError: type should is not implemented for QueryType
@vrcmarcos
Copy link
Owner

I think that this PR solved this issue. Am I right?

Ty for the improvement! If you are still having issues, please reopen this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vrcmarcos @lunarie16