Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open external URLs in comments #490

Open
igor-ye opened this issue Jun 7, 2018 · 8 comments
Open

Open external URLs in comments #490

igor-ye opened this issue Jun 7, 2018 · 8 comments

Comments

@igor-ye
Copy link

igor-ye commented Jun 7, 2018

It would be great if Poedit will be able to open http links stored in source line comments either in embedded or in default system browser. It would be really helpful for translating PO files generated not from source code.
So for message like this

#: https://example.com/some-url
msgid "Some text"
msgstr ""

on click on References item in context menu Poedit should open https://example.com/some-url in browser instead of showing popup with message "Error opening file https!".

Or maybe just make http links in Notes for translators clickable same way.

@vslavik
Copy link
Owner

vslavik commented Jun 7, 2018

It would indeed be great. PR by a chance?

Would you have some actual real-life example of this? I'm only aware of Crowdin's such use in XLIFF files (and those link to screenshots only).

@igor-ye
Copy link
Author

igor-ye commented Jun 7, 2018

I'm surely not a C++ guy, sorry

We are using Poedit to translate strings for our front-end and it works great here. Now we are going to improve translation process for external strings fetched from postal services APIs. As that strings sometimes are misspelled, sometimes extracted incorrectly or just to short to understand what it means by itself so it would be useful if translator can just click the link, open the page with full path of package ( like this https://postal.ninja/en/track/-BG6w18x or even like this https://postal.ninja/en/track/-qwxabnp ) and check if strings were extracted and parsed correctly and what step in delivery process this message was used for.
I know that's not the intended way to use gettext but at the moment I'm looking for ways to (re-)use existing (and handy) tools instead of developing some in-house translation system.

@vslavik vslavik changed the title Open external URLs stored in source line comments Open external URLs in comments Jun 7, 2018
@vslavik
Copy link
Owner

vslavik commented Jun 7, 2018

Translation: no such PO files actually exist and you're asking me to implement custom functionality for your internal use. Your answer is an awful lot of theorizing about what "would" be "useful", but you didn't demonstrate any actual usefulness today. You'll understand why I'm not particularly eager to spend implementing something that your company might perhaps some day use internally — especially when you yourself don't care about the functionality to be willing to actually do something about it yourself (nobody is born a "C++ guy", those can be hired, etc. etc.).

I'm leaving this open because I recognize the theoretical usefulness, but don't expect anything to happen about it anytime soon unless somebody steps up.

@igor-ye
Copy link
Author

igor-ye commented Jun 7, 2018

Maybe no such files not because of that's useless but because gettext is still stuck in late 90s?
So another example of theoretical usefulness in our age of everyone-goes-to-the-cloud:

#: https://github.com/vslavik/poedit/blob/master/src/attentionbar.cpp#L37
#: https://gitlab.com/fdroid/fdroidclient/blob/master/app/src/main/java/org/fdroid/fdroid/AboutActivity.java#L9
#: url-to-intranet-hosted-gitlab
msgid "Some text"
msgstr ""

Anyway I see you point. Of course this will only be useful when coupled with PO-file generator supporting such feature. Obviously GNU gettext is not the case.

@vslavik
Copy link
Owner

vslavik commented Jun 7, 2018

Maybe no such files not because of that's useless but because gettext is still stuck in late 90s?

Maybe tone down the arrogance a notch and show some respect to GNU folks.

Please also pay a bit more attention when reading: I did not say that handling links in comments is useless (see also: this issue is still not closed). I said that it wouldn't be useful to have support in Poedit now if nobody would use such feature because such files don't exist.

So another example of theoretical usefulness in our age of everyone-goes-to-the-cloud:

Igor, if somebody asks you to provide an example real-life file, showing theoretical examples of what files might look like is not answering that. I'm not a complete buffoon, I get it. What you don't seem to get is that practically speaking there's little point in doing this now.

If you disagree and think this is useful, put your money where your mouth is. But arguing over it on the Internet, with the expectation that others will fulfill your wishes, or being rude and insulting to the people that spent decades actually putting work in is not the way to go about it.

Repository owner locked as too heated and limited conversation to collaborators Jun 7, 2018
Repository owner unlocked this conversation Jun 8, 2018
@rillig
Copy link

rillig commented Apr 2, 2019

I can provide a practical use case.

I'm translating GCC 9 at the moment. In 2017, while translating GCC 7, I filed many bug reports that I mentioned in the message comment of each affected message. See the de.po file from GCC 8, just search for https.

I'd like to visit these bug reports by simply clicking on them, instead of pressing Ctrl+M, Ctrl+A, Win+3, Ctrl+T, Ctrl+V, Enter.

Edit (VS): uploaded copy of gcc file: gcc-12.2.0-de.po.zip

@vslavik

This comment has been minimized.

@vslavik
Copy link
Owner

vslavik commented Oct 14, 2022

Note to self: this will require a move to read-only wxTextCtrl as discussed in #230.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants