Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcpkg integration #238

Open
daschuer opened this issue Jan 9, 2022 · 1 comment
Open

vcpkg integration #238

daschuer opened this issue Jan 9, 2022 · 1 comment

Comments

@daschuer
Copy link
Contributor

daschuer commented Jan 9, 2022

VCPKG is a C++ Library Manager for Windows https://github.com/microsoft/vcpkg
It is driven by cmake and allows to integrate libraries with various build systems like msbuild.

I have crated a port for WinSpakles here microsoft/vcpkg#17563

During the code review I have been ask to link against the libraries that are already build by vcpkg and not against the source 3rdparty library.

What is the best way to do it?

Is there a chance that the required changes are integrated here?

@vslavik
Copy link
Owner

vslavik commented Jan 15, 2022

What is the best way to do it?

None.

Is there a chance that the required changes are integrated here?

Frankly, no.

It is an explicit design goal for WinSparkle to be a single self-contained DLL with no external dependencies (to the point that it even links to static CRT!). This matters for e.g. in-app delta updates or re-launching the app after update (which, OK, aren't implemented yet) when WinSparkle code requires special handling to keep running. As long as that means just a single WinSparkle.dll and nothing else, it is manageable.

I'd really appreciate it if something as high-profile as Vcpkg didn't provide non-standard builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants