Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCRAM-SHA-1 + SCRAM-SHA-256 + SCRAM-SHA-512 supports #153

Closed
Neustradamus opened this issue Sep 9, 2019 · 18 comments
Closed

SCRAM-SHA-1 + SCRAM-SHA-256 + SCRAM-SHA-512 supports #153

Neustradamus opened this issue Sep 9, 2019 · 18 comments

Comments

@Neustradamus
Copy link

Neustradamus commented Sep 9, 2019

"When using the SASL SCRAM mechanism, the SCRAM-SHA-256-PLUS variant SHOULD be preferred over the SCRAM-SHA-256 variant, and SHA-256 variants [RFC7677] SHOULD be preferred over SHA-1 variants [RFC5802]".

SCRAM-SHA-1(-PLUS):

SCRAM-SHA-256(-PLUS):

SCRAM-SHA-512(-PLUS):

SCRAM-SHA3-512(-PLUS):

SCRAM BIS: Salted Challenge Response Authentication Mechanism (SCRAM) SASL and GSS-API Mechanisms:

-PLUS variants:

IMAP:

LDAP:

  • RFC5803: Lightweight Directory Access Protocol (LDAP) Schema for Storing Salted: Challenge Response Authentication Mechanism (SCRAM) Secrets: https://tools.ietf.org/html/rfc5803

HTTP:

JMAP:

2FA:

IANA:

Linked to:

@dfish3r
Copy link
Member

dfish3r commented Sep 17, 2019

@dhawes can our OpenLDAP docker image support this?

@dhawes
Copy link
Contributor

dhawes commented Sep 17, 2019

I've pushed an image that supports:

SCRAM-SHA-1
SCRAM-SHA-224
SCRAM-SHA-256
SCRAM-SHA-384
SCRAM-SHA-512

by using cyrus-sasl git master [1].

PLUS support will have to wait until Cyrus SASL supports it.

[1] cyrusimap/cyrus-sasl#552

@Neustradamus
Copy link
Author

Neustradamus commented Oct 1, 2019

@dhawes: Please look:
https://github.com/cyrusimap/cyrus-sasl/commits/master

  • Commits from Sep 2, 2019
  • Commits from Sep 4, 2019

Thanks a lot to @aamelnikov and @ksmurchison too.

@Neustradamus
Copy link
Author

@dhawes: Have you looked for -PLUS variants, already in master?

@dhawes
Copy link
Contributor

dhawes commented Nov 20, 2019

I see a documentation update, but no commits. Can you reference a commit where this was added?

cyrusimap/cyrus-sasl#552 is still open as well.

@Neustradamus
Copy link
Author

@dhawes: It was already done.

If you have problem, please inform.

I have requested to the author (@aamelnikov).

And there was a problem of documentation, and some links are not good yet:

@dhawes
Copy link
Contributor

dhawes commented Nov 20, 2019

cyrusimap/cyrus-sasl#552 claims that adding -PLUS will take a lot more work. I don't see that work in any commits.

The search you link shows updates to support mech lists. It's unclear if those mechs are actually supported.

I tried the latest master to see if support exists, but I am unable to use any -PLUS variants. Have you attempted to use -PLUS with cyrus-sasl?

@dfish3r
Copy link
Member

dfish3r commented Nov 25, 2019

Added support for SCRAM in this PR:
#160

@Neustradamus
Copy link
Author

@dfish3r: Thanks a lot :)

@Neustradamus
Copy link
Author

@dfish3r: Little question, what is missing for -PLUS variants?

@dfish3r
Copy link
Member

dfish3r commented Nov 27, 2019

As @dhawes mentioned, PLUS doesn't appear to be supported yet in cyrus-sasl. Since that is our testing platform we won't proceed with any development until those features are available.

@dfish3r
Copy link
Member

dfish3r commented Dec 7, 2019

v2 merged into master. Please test these mechanisms when you have a chance.

@dfish3r dfish3r closed this as completed Dec 7, 2019
@Neustradamus
Copy link
Author

@dfish3r: Thanks for SCRAM-SHA-1/SCRAM-SHA-256/SCRAM-SHA-512.

Can I create a new ticket for -PLUS variants?

@dfish3r
Copy link
Member

dfish3r commented Jan 6, 2020

Thanks for SCRAM-SHA-1/SCRAM-SHA-256/SCRAM-SHA-512.

Did you test these?

Can I create a new ticket for -PLUS variants?

Sure.

@Neustradamus
Copy link
Author

Not really :/

@Neustradamus Neustradamus changed the title SCRAM-SHA-1(-PLUS) + SCRAM-SHA-256(-PLUS) supports SCRAM-SHA-1 + SCRAM-SHA-256 + SCRAM-SHA-512 supports Jan 6, 2020
@Neustradamus
Copy link
Author

@dfish3r
Copy link
Member

dfish3r commented Jan 7, 2020

It will be awhile before I look at the -PLUS implementation. Please make comments on that issue.

@Neustradamus
Copy link
Author

Neustradamus commented Aug 25, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants