New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shelf bug report #213

Open

Erislandio opened this issue Feb 12, 2020 · 4 comments

Erislandio commented Feb 12, 2020

Shelf bug report

Current Behavior

when the shelf is loaded several react errors appear on the console
** main problem is the infinite loop

Print: https://share.getcloudapp.com/12u1xexB

Steps to Reproduce (for bugs)

go to https://shop.samsung.com.ar
open dev tools
check the dev tools console

Possible Solution

check that line of code: https://github.com/vtex-apps/shelf/blob/master/react/components/ShelfContent.js#L65

Your Environment

Version used: 1.34.4
Environment name and version: Version 79.0.3945.130
Operating System and version (desktop or mobile): windows 10 / windows 7
Link to your project: https://shop.samsung.com.ar

Contributor

klzns commented Feb 12, 2020 •

edited

Loading

Could not reproduce in http://shop.samsung.com.pe/

Video: https://giphy.com/gifs/Pm3IKcD9yYF4srBMy5/fullscreen

Neither at https://shop.samsung.com.ar/dispositivos-moviles/smartphones?order=OrderByReleaseDateDESC&page=2

Contributor

klzns commented Feb 12, 2020

How to reproduce:

Open https://shop.samsung.com.pe/
Open Chrome Dev Tools in mobile view, like iPhone X
Wait a few seconds
This will show up

Author

Erislandio commented Feb 12, 2020

is exactly that error

Contributor

klzns commented Feb 12, 2020 •

edited

Loading

Thanks! We added to our backlog. I'll keep you updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment