feat: remove use of bitflags, flatten var modifiers

This removes a dependency, and makes the code cleaner. There is no longer a possibility of having a xor range or base64 alphabet without the corresponding flag, and the code is globally simpler.
vthib · Apr 7, 2023 · 05877aa · 05877aa
1 parent ec2e0aa
commit 05877aa
Show file tree

Hide file tree

Showing 7 changed files with 299 additions and 234 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/boreal-parser/Cargo.toml b/boreal-parser/Cargo.toml
@@ -15,8 +15,5 @@ rust-version = "1.62"
 # Parsing library
 nom = "7.1"
 
-# packing multiple flags together
-bitflags = "1.3"
-
 # Proper error reporting on parsing
 codespan-reporting = "0.11"
diff --git a/boreal-parser/src/lib.rs b/boreal-parser/src/lib.rs
@@ -58,7 +58,8 @@ pub mod regex;
 pub use regex::Regex;
 mod rule;
 pub use rule::{
-    Metadata, Rule, VariableDeclaration, VariableDeclarationValue, VariableFlags, VariableModifiers,
+    Metadata, Rule, VariableDeclaration, VariableDeclarationValue, VariableModifierBase64,
+    VariableModifiers,
 };
 mod string;
 mod types;