Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: menu cannot be collapsed by the layout #2819

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

John60676
Copy link
Member

@John60676 John60676 commented Sep 9, 2020

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. 重现地址:antdv文档-Layout组件-侧边布局
  2. 重现方式:菜单组件在展开二级菜单时,折叠Layout sider,子菜单无法跟随折叠.
  3. 出现该问题是因为vue3中的 watch options 不再支持 key expressions 的方式使用 [Docs should be clearer about watch option keys not supporting key paths vuejs/core#2003]。因此导致 Menu 组件中无法 watchlayoutSiderContext.sCollapsed.

Kapture 2020-09-09 at 23 59 28

image

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@tangjinzhou tangjinzhou merged commit c1cfabb into vueComponent:feat-vue3 Sep 17, 2020
@John60676 John60676 deleted the fix-menu-collapsed branch September 17, 2020 08:00
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants