Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the button's loading property without delay #3194

Merged
merged 1 commit into from
Nov 17, 2020
Merged

fix: the button's loading property without delay #3194

merged 1 commit into from
Nov 17, 2020

Conversation

nanjingcaiyong
Copy link
Contributor

@nanjingcaiyong nanjingcaiyong commented Nov 17, 2020

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. 设置button组件loading属性值为{delay: 3000}无效

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. It is invalid to set the value of button component loading property to {delay: 3000}. Check the ant design Vue's button.jsx File code. It is found that the value of sLoading attribute returned in data is props.loading If loading is set to object type in the parent component, the sLoading value of the child component is set to true, and the delay function fails
  2. 设置button组件loading属性值为{delay: 3000}无效,查看ant-design-vue的button.jsx文件代码,发现data中返回的sLoading属性值是将props.loading转为boolean类型,导致在父组件设置loading为object类型则子组件的sLoading赋值为true,delay功能失效

@tangjinzhou tangjinzhou merged commit 87e5985 into vueComponent:next Nov 17, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants