Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: radio cancel change #3517

Merged
merged 2 commits into from
Jan 14, 2021
Merged

Conversation

zkwolf
Copy link
Member

@zkwolf zkwolf commented Jan 11, 2021

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
  2. Resolve what problem.
  3. Related issue link.

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@zkwolf zkwolf changed the title fix: radio cancel change #3047 fix: radio cancel change Jan 11, 2021
@@ -87,6 +87,10 @@ export default defineComponent({
this.__emit('update:checked', eventObj);
this.__emit('change', eventObj);
this.eventShiftKey = false;
// fix https://github.com/vueComponent/ant-design-vue/issues/3047
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

放到这行前面吧
this.$forceUpdate(); // change前,维持现有状态

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tangjinzhou tangjinzhou merged commit 2904cee into vueComponent:next Jan 14, 2021
@tangjinzhou
Copy link
Member

1.x 也可以pr一个

@zkwolf
Copy link
Member Author

zkwolf commented Jan 14, 2021

1.x早就修了

@zkwolf
Copy link
Member Author

zkwolf commented Jan 14, 2021

拖延了好久我才想起来pr到2.x

@zkwolf zkwolf deleted the fix-radio-change branch January 14, 2021 03:03
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants