-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: carousel's pauseOnDotsHover not work #3519
fix: carousel's pauseOnDotsHover not work #3519
Conversation
确认一下吧,试了一下pauseOnDotsHover是生效的 |
2021-01-12.11.39.31.mov |
你这个demo是1.x版本的吧。。 |
https://codesandbox.io/s/nostalgic-water-juux5?file=/src/main.js |
|
@@ -635,7 +635,7 @@ export default { | |||
dotProps = { | |||
...dotProps, | |||
clickHandler: this.changeSlide, | |||
onMouseenter: pauseOnDotsHover ? this.onDotsLeave : noop, | |||
onMouseenter: pauseOnDotsHover ? this.onDotsOver : noop, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can delete onMouseenter event.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
确实,这块onMouseover和onMouseenter处理情况有重复的地方。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pauseOnHover 相关的 onMouseenter应该也可以删除,😂 。
删掉那一行应该没什么问题 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This is a ...
What's the background?
API Realization (Optional if not new feature)
What's the effect? (Optional if not new feature)
Changelog description (Optional if not new feature)
Self Check before Merge