Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(date-picker): when default slot is a comment node, date-picker will not display #4105

Merged
merged 1 commit into from
May 23, 2021

Conversation

meteor199
Copy link
Contributor

@meteor199 meteor199 commented May 20, 2021

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
  2. Resolve what problem.
    当 date-picker 中有注释节点时,date-picker不会显示,因为注释节点也可以作为一个 default slot,它会覆盖默认的input
  <a-date-picker>
    <!-- aaa -->
  </a-date-picker>
  1. Related issue link.
    https://codesandbox.io/s/zen-nightingale-kwntz?file=/src/App.vue

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
    判断下default slot是否是空节点,假如是空节点,则使用默认的input,否则使用传进来的default slot。
    其他方法:
  • 不使用 default slot作为默认的自定义渲染,但是需要修改文档且有破坏性更新
  1. List final API realization and usage sample.
    判断下default slot是否是空节点,假如是空节点,则使用默认的input,否则使用传进来的default slot
  2. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@tangjinzhou tangjinzhou merged commit f437e91 into vueComponent:next May 23, 2021
@meteor199 meteor199 deleted the fix-date-picker-comment branch May 25, 2021 01:17
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants